Fix #60, rework loop in CF_CFDP_CycleTx #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the loop inside this function to be more conventional, and easier to follow. Does not change the logic.
jphickey
added
the
CCB:Ready
skliper
approved these changes
Jan 12, 2022
astrogeco
removed
the
CCB:Ready
|
CCB:2022-01-19 APPROVED
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Modifies the loop inside this function to be more conventional, and easier to follow. Does not change the logic.
Fixes #60
Testing performed
Build and sanity check CF, run all tests
Expected behavior changes
None, this does not change loop logic
System(s) tested on
Ubuntu 21.10
Additional context
Do not use "goto" to jump inside the middle of a loop, just use
while(true)and break out when the stop condition was reached.Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.