Fix #61, remove dependence on ENDIAN macro for checksum #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Removes the checksum "optimization" for big endian, as it is unlikely to be useful and creates endianness dependencies.
Fixes #61
Testing performed
Build and sanity check CF
Expected behavior changes
None on x86/little endian (removes code that was not used)
PPC/big endian will use the same code as x86, might be a bit slower but its safer and more testable (because its the same code)
System(s) tested on
Ubuntu 21.10
Additional context
The big endian optimization is probably not that useful because it requires that the HW can do misaligned 32-bit reads. AFAIK most embedded CPUs do not have this capability, and if they can, it might not be all that much faster than reading it byte-by-byte. So even though it looks like a 32-bit read in C code (and therefore 4x fewer loop iterations) it probably doesn't have much of a payoff, if one could find a hardware with this capability (not sure how it was originally tested). In the end I don't think its worth trying to test and maintain this "optimization".
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.