Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #148, use proper types for MsgId and mid values #150

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Jan 6, 2022

Ensures use of the proper SB-provided types for MsgIDs and MsgId values (aka CFE_SB_MsgId_Atom_t). This ensures that
the values are used and converted properly.

Fixes #148

@jphickey
Copy link
Contributor Author

jphickey commented Jan 6, 2022

For review, see commit f799f92 specifically.

This PR will need to be rebased once #137 is merged.

@jphickey jphickey requested a review from skliper January 6, 2022 20:30
@skliper
Copy link
Contributor

skliper commented Jan 6, 2022

Just a name thing, but how about changing apid_* to mid_*, since apid really does mean something else to some people.

Ensures use of the proper SB-provided types for MsgIDs and
MsgId values (aka CFE_SB_MsgId_Atom_t).  This ensures that
the values are used and converted properly.
@jphickey
Copy link
Contributor Author

jphickey commented Jan 6, 2022

Just a name thing, but how about changing apid_* to mid_*, since apid really does mean something else to some people.

Good point, they in fact are definitely different things.

@jphickey jphickey marked this pull request as ready for review January 6, 2022 22:35
@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 10, 2022
@astrogeco astrogeco merged commit cfe2881 into nasa:main Jan 12, 2022
@jphickey jphickey deleted the fix-148-msgid-type branch January 12, 2022 16:52
@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 19, 2022
@astrogeco
Copy link
Contributor

astrogeco commented Jan 19, 2022

CCB:2022-01-19 APPROVED

  • Makes message IDs compatible with Draco

@skliper skliper added this to the Draco milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants