Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #247, Move sample_libs into libraries dir #335

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Aug 10, 2021

Checklist (Please check before submitting)

Describe the contribution
Creates a new directory "libs" at the cFS bundle level to put libraries in. This will create a little more clarity between applications and libraries

Fixes #247

Testing performed
CI Ubuntu

Expected behavior changes
None, everything should still compile

System(s) tested on
Ubuntu 18.04

Additional context
Might require developers to fixup their local repos once change is merged

Set default branch for submodules in .gitmodules to "main"
@astrogeco astrogeco requested review from skliper and jphickey August 10, 2021 18:29
@skliper
Copy link
Contributor

skliper commented Aug 11, 2021

Consider postponing until Draco? Seems a bit unkind to break everyone's checked out bundle this late in the cycle.

@skliper
Copy link
Contributor

skliper commented Aug 11, 2021

Missing issue link.

@astrogeco
Copy link
Contributor Author

I think the only way it would break is if people have local "non-main" sample_lib branches

@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Aug 11, 2021
@astrogeco
Copy link
Contributor Author

CCB:2021-08-11 APPROVED

  • Might need to have users "resync" their submodules

@astrogeco astrogeco changed the base branch from main to integration-candidate August 17, 2021 17:30
@astrogeco astrogeco force-pushed the integration-candidate branch from c2119ea to 94721a6 Compare August 17, 2021 17:33
@astrogeco astrogeco merged commit e631fbb into nasa:integration-candidate Aug 17, 2021
@astrogeco astrogeco deleted the 247-use-libs-dir branch August 17, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create separate app and libraries directories
2 participants