Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate app and libraries directories #247

Closed
astrogeco opened this issue Apr 21, 2021 · 2 comments · Fixed by #335
Closed

Create separate app and libraries directories #247

astrogeco opened this issue Apr 21, 2021 · 2 comments · Fixed by #335

Comments

@astrogeco
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Having libraries in the apps folder can be confusing especially for beginners.

Describe the solution you'd like
New directory called "lib" or "libs" where libraries can "live"

Describe alternatives you've considered
Add documentation justifying why it "makes sense" to keep libraries in the apps directory

@astrogeco astrogeco changed the title Separate app and libraries Create separate app and libraries directories Apr 21, 2021
@jphickey
Copy link
Contributor

This already exists, there is a "libs" dir (equivalent to apps) as part of the search path already. We just don't use it in the bundle. All we need to do is move e.g. "sample_lib" submodule from apps into libs in the bundle and it should just work.

@astrogeco
Copy link
Contributor Author

Awesome! I can try that next week

astrogeco added a commit that referenced this issue Aug 17, 2021
Fix #247, Move sample_libs into libraries dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants