-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #227, Add input so users can specify the parameter description #206
Conversation
CCB 8 September 2022: Needs an issue. |
@HugoValente11 Thank you for your contribution! Would you be able to create an issue for this PR? |
My bad, when I saw self-assigned I thought that you'd create the issue, didn't realize that you were waiting for me to create it to close the pull. Sure created it now |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @HugoValente11 , would you please change the commit message to follow our cFS contribution convention?---> Fix #XYZ, SHORT_DESCRIPTION
One way to do this is to use git commit --amend
(change commit message) and then git push --force
from your local branch.
The final commit message may look like: "Fix #227, Add input so users can specify the parameter description
All of the checks are marked as passed, however "Error: The log was not found. It may have been deleted based on retention settings." is the error message displayed in the details of each job in the checks. This gives uncertainty if the passes are true. |
CCB 20 October 2022: @dzbaker will attempt to re-run workflows. |
Fixed |
@HugoValente11 Would you be able to rebase this with main? |
*Combines:* cFS-GroundSystem v3.0.0-rc4+dev43 **Includes:** *cFS-GroundSystem* - nasa/cFS-GroundSystem#206 Co-authored by: Hugo Valente <[email protected]>
*Combines:* cFS-GroundSystem v3.0.0-rc4+dev43 **Includes:** *cFS-GroundSystem* - nasa/cFS-GroundSystem#206 Co-authored by: Hugo Valente <[email protected]>
Describe the contribution
The default behavior for the param description was to be considered null. However I found this not to be very user friendly since if you didn't have the source code with the accepted values you couldn't create a valid command to send.
My solution was to add an input after specifying a parameter in order for the description of the parameter to be saved.
This way when we open GroundSystem and start creating a command to send, we have some guidelines about the acceptable inputs for the arguments
Screenshot of how the GUI has been affected:
https://ibb.co/9TKXB51
Testing performed
Steps taken to test the contribution:
Expected behavior changes
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Hugo Micael Santos Valente / STRAST / UPM