Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1712, Make successful command events INFO type #2575

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

Expected behavior changes
As above.

System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

@thnkslprpt
Copy link
Contributor Author

@jphickey do you know why the test is failing?
Seems to be something to do with the event types being masked or the tests expecting only DEBUG for some cases where I've changed it to INFO?

@@ -747,7 +747,7 @@

if (Status == CFE_SUCCESS)
{
CFE_EVS_SendEventWithAppID(CFE_SB_GETPIPENAME_EID, CFE_EVS_EventType_DEBUG, CFE_SB_Global.AppId,
CFE_EVS_SendEventWithAppID(CFE_SB_GETPIPENAME_INF_EID, CFE_EVS_EventType_INFORMATION, CFE_SB_Global.AppId,

Check warning

Code scanning / CodeQL

Uses of recursion Warning

The function CFE_SB_GetPipeName is indirectly recursive via this call to
CFE_EVS_SendEventWithAppID
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Most commands only generate DEBUG event for successful completion
1 participant