Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use XOR for ping-pong buffer in TBL #1514

Open
skliper opened this issue May 13, 2021 · 0 comments · May be fixed by #2351
Open

Use XOR for ping-pong buffer in TBL #1514

skliper opened this issue May 13, 2021 · 0 comments · May be fixed by #2351
Labels
CFS-43 enhancement

Comments

@skliper
Copy link
Contributor

skliper commented May 13, 2021

Is your feature request related to a problem? Please describe.
Current pattern use for the active/inactive buffer index isn't as obvious/common (1 - index), examples but needs full scrub:

cFE/modules/tbl/fsw/src/cfe_tbl_internal.c

Line 680 in 84ba9a9

*WorkingBufferPtr = &RegRecPtr->Buffers[(1U - RegRecPtr->ActiveBufferIndex)];

cFE/modules/tbl/fsw/src/cfe_tbl_internal.c

Line 711 in 84ba9a9

InactiveBufferIndex = 1 - RegRecPtr->ActiveBufferIndex;

Describe the solution you'd like
index^1

Describe alternatives you've considered
Current implementation works, this is just style

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CFS-43 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1514, Use XOR to swap between ping-pong buffers (style change only) thnkslprpt/cFE
1 participant
@skliper