Fix #1514, Use XOR to swap between ping-pong buffers (style change only)
#2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1156,12 +1156,12 @@ | |||
| { | |||
| /* Call the Application's Validation function for the Inactive Buffer */ | |||
| Status = | |||
| (RegRecPtr->ValidationFuncPtr)(RegRecPtr->Buffers[(1U - RegRecPtr->ActiveBufferIndex)].BufferPtr); | |||
| (RegRecPtr->ValidationFuncPtr)(RegRecPtr->Buffers[(RegRecPtr->ActiveBufferIndex ^ 1)].BufferPtr); | |||
Check notice
Code scanning / CodeQL
Use of non-constant function pointer Note
| @@ -1096,7 +1096,7 @@ | |||
| UT_InitData(); | |||
| DumpCmd.Payload.ActiveTableFlag = CFE_TBL_BufferSelect_INACTIVE; | |||
| CFE_TBL_Global.Registry[2].DoubleBuffered = true; | |||
| CFE_TBL_Global.Registry[2].Buffers[(1 - CFE_TBL_Global.Registry[2].ActiveBufferIndex)].BufferPtr = BuffPtr; | |||
| CFE_TBL_Global.Registry[2].Buffers[(CFE_TBL_Global.Registry[2].ActiveBufferIndex ^ 1)].BufferPtr = BuffPtr; | |||
Check warning
Code scanning / CodeQL
Local variable address stored in non-local memory Warning
| @@ -712,7 +712,7 @@ | |||
| UT_InitData(); | |||
| ValidateCmd.Payload.ActiveTableFlag = CFE_TBL_BufferSelect_INACTIVE; | |||
| CFE_TBL_Global.Registry[0].DoubleBuffered = true; | |||
| CFE_TBL_Global.Registry[0].Buffers[1 - CFE_TBL_Global.Registry[0].ActiveBufferIndex].BufferPtr = BuffPtr; | |||
| CFE_TBL_Global.Registry[0].Buffers[CFE_TBL_Global.Registry[0].ActiveBufferIndex ^ 1].BufferPtr = BuffPtr; | |||
Check warning
Code scanning / CodeQL
Local variable address stored in non-local memory Warning
thnkslprpt
force-pushed
the
fix-1514-use-XOR-to-swap-ping-pong-buffers
branch
from
283aa6c
to
e133e03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
1 - ActiveBuffertoActiveBuffer ^ 1.Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
No change to behavior.
Contributor Info
Avi Weiss @thnkslprpt