Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CFE_TBL_SearchCmdHndlrTbl to unmix error codes with indexes and simplify loop #1519

Open
skliper opened this issue May 13, 2021 · 0 comments · May be fixed by #2332
Open

Refactor CFE_TBL_SearchCmdHndlrTbl to unmix error codes with indexes and simplify loop #1519

skliper opened this issue May 13, 2021 · 0 comments · May be fixed by #2332
Labels
CFS-43 enhancement

Comments

@skliper
Copy link
Contributor

skliper commented May 13, 2021

Is your feature request related to a problem? Please describe.
Mixes error codes (at least by name) with an index:

cFE/modules/tbl/fsw/src/cfe_tbl_task.c

Line 340 in 84ba9a9

int16 TblIndx = CFE_TBL_BAD_CMD_CODE;

also the do/while loop is unnecessarily complex in how it exits (has to check for last entry twice).

Describe the solution you'd like
Consider a simpler while or for loop with a break, don't mix index w/ a command code.

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper mentioned this issue May 13, 2021
Open
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue May 9, 2023
@thnkslprpt
Fix nasa#1519, Refactor CFE_TBL_SearchCmdHndlrTbl to simplify and u…
5e55cc7 
…nmix variables
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue May 9, 2023
@thnkslprpt
Fix nasa#1519, Refactor CFE_TBL_SearchCmdHndlrTbl to simplify and u…
8466132 
…nmix variables
@thnkslprpt thnkslprpt linked a pull request May 9, 2023 that will close this issue
Open
2 tasks
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Oct 26, 2023
@thnkslprpt
Fix nasa#1519, Refactor CFE_TBL_SearchCmdHndlrTbl to simplify and u…
d9b51fb 
…nmix variables
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Apr 19, 2024
@thnkslprpt
Fix nasa#1519, Refactor CFE_TBL_SearchCmdHndlrTbl to simplify and u…
29b15c8 
…nmix variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CFS-43 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1519, Refactor CFE_TBL_SearchCmdHndlrTbl to simplify and unmix variables thnkslprpt/cFE
1 participant
@skliper