Fix #2282, Move calls to CFE_SB_GetPipeName() up higher to reduce duplication #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1676,13 +1676,13 @@ | |||
| /* send an event for each pipe write error that may have occurred */ | |||
| for (i = 0; i < SBSndErr.EvtsToSnd; i++) | |||
| { | |||
| CFE_SB_GetPipeName(PipeName, sizeof(PipeName), SBSndErr.EvtBuf[i].PipeId); | |||
Check warning
Code scanning / CodeQL
Uses of recursion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
GetPipeName()to reduce code duplication inBroadcastBufferToRoute()#2282CFE_SB_GetPipeName()reduced to 1 by moving it up to the start of theforloop block.The
PipeNameis now ready to use in any of the error blocks if needed.Testing performed
GitHub CI actions all passing successfully.
A couple of the coverage tests which were checking the error conditions but suppressing the actual sending of an event now have the extra event generated by
CFE_SB_GetPipeName()from earlier in theforblock.#2265 will remove the event from nominal execution of
CFE_SB_GetPipeName()anyway, so these event counts will go back down once that is merged (also the call will no longer be 'indirectly recursive').Expected behavior changes
No change to behavior other than that described above.
Contributor Info
Avi Weiss @thnkslprpt