Fix #1332, Resolve compiler warnings re. signedness comparisons #2247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
MinSystemState
representsCFE_ES_SystemState
values. Seems safe (and future-proof) to cast to a simpleint
given the possible range of these values.ElapsedTime
casted toint64_t
instead ofint
/int32
to guarantee no conceivable chance of overflow even with (very) large msec time values.BlockSize
used to represent the size of various structures - fine to cast to standardint
.StringLength
type changed tosize_t
(more correct given it's usage, and avoids 2 signedness comparison warnings).RecordSize
represents number of bytes - maybe safest withint64_t
.TblSizeInBytes
represents number of bytes (safest withint64_t
)Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Tested locally with
-Wsign-compare
flag enabled - no warnings issued for cFE.Expected behavior changes
No change to behavior.
Contributor Info
Avi Weiss @thnkslprpt