New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1117, Rename unclear FileWrite EIDs #2241

Open

thnkslprpt wants to merge 1 commit into nasa:main from thnkslprpt:fix-1117-rename-misnomer-EIDs

Contributor

thnkslprpt commented Feb 4, 2023 •

edited

Loading

Checklist

I reviewed the Contributing Guide.
I signed and emailed the appropriate Contributor License Agreement to [email protected] and copied [email protected].

Describe the contribution

Fixes CFE_SB_SND_RTG_EID and CFE_SB_SND_RTG_ERR1_EID used for all three write file cmds (route, map, pipe) #1117
- Replaces misnamed/unclear FileWrite EIDs:
  - CFE_SB_SND_RTG_EID replaced with: CFE_SB_FILE_WRITE_EID
  - CFE_SB_FILEWRITE_ERR_EID replaced with: CFE_SB_FILE_WRITE_ERR_EID (minor change, purely for format consistency)
  - CFE_SB_SND_RTG_ERR1_EID replaced with: CFE_SB_FILE_WRITE_CR_ERR_EID

These EIDs are still overloaded. The aim to eventually make them unique is still open in issue #1588

Note: unrelated minor typo piggy-backed onto this PR (to to).

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
No change to code behavior.
Future maintainability and ease-of-use improved due to clearer EID names.

Contributor Info
Avi Weiss @thnkslprpt


          Fix nasa#1117, Rename unclear FileWrite EIDs

dd569b0

thnkslprpt force-pushed the fix-1117-rename-misnomer-EIDs branch from 5d7b37f to dd569b0 Compare

May 5, 2023 03:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet