Fix #1985, Check return value of CFE_ES_PutPoolBuf

[thnkslprpt]

Checklist

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License Agreement to [email protected] and copied [email protected].

Describe the contribution

• Fixes Check Return Value of CFE_ES_PutPoolBuf #1985
  • Adds a WriteToSysLog for the single remaining CFE_ES_PutPoolBuf() call that didn't have a check/report of any kind.

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
In case of error, the relevant details will be written to the log.

Alternative considered
Simpler version:

Contributor Info
Avi Weiss @thnkslprpt

[skliper]

Consider only writing once to avoid flooding the log. Might be one of the errors that would be helpful to track w/ something in HK, as a system health indicator. See #1469.

[thnkslprpt]

Jake @skliper, how would I go about limiting it to one write?
Cheers

[skliper]

Relates to:

• Add service "health" parameter to HK (and provide a suggested pattern for apps to follow) #1469

It's a bigger conceptual change, but I'm a big fan of persistent indication of system health/issues of this flavor. So if there was a bitfield/counter or similar in HK to track these sort of issues, you could only print if there wasn't a previous failure of this type indicated.