Fix #1461, Move data lock to inside of if block #2198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
if
statement inCFE_SB_ReleaseMessageBuffer
#1461if
block (lock is not needed if theif
block condition doesn't evaluate totrue
).Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
Data lock will not occur in the (unexpected) case of an error return from
CFE_SB_ZeroCopyBufferValidate()
, which is fine as no data would be accessed/amended in that case anyway.Contributor Info
Avi @thnkslprpt