Fix #1450, Remove duplicate status check #2185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thnkslprpt
force-pushed
the
fix-1450-remove-duplicate-status-check
branch
from
69c981c
to
0e88250
Compare
|
Noticed second case of the same issue (redundant repeat status check) and added to this PR with a second commit (and squashed them). |
thnkslprpt
force-pushed
the
fix-1450-remove-duplicate-status-check
branch
from
0e88250
to
5f746e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CFE_EVS_EnableAppEventTypeCmd#1450Status == CFE_SUCCESS) and moves event report (EVS_SendEvent(CFE_EVS_ENAAPPEVTTYPE_EID...) to earlier in function.Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No impact on behavior.
Logic does not change as the event is still sent in first
if (Status == CFE_SUCCESS).Contributor Info
Avi Weiss @thnkslprpt