Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2095, Automatic suppression of flooding events #2117

Merged
merged 5 commits into from
Aug 4, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jun 9, 2022

Checklist (Please check before submitting)

Describe the contribution

Testing performed
CI

Expected behavior changes
Squelches flooding events (configurable)

System(s) tested on
CI

Additional context
Still a work in progress, needs coverage and functional cleanup

Third party code
None, update suggestion from NASA/JSC context.

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

Ping @jhnphm

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 30 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 30 potential problems in the proposed changes. Check the Files changed tab for more details.

@skliper skliper requested a review from tngo67 June 9, 2022 20:08
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 29 potential problems in the proposed changes. Check the Files changed tab for more details.

@skliper skliper removed the request for review from tngo67 June 16, 2022 14:41
@skliper skliper requested a review from semaldona July 13, 2022 15:56
** \par Limits
** This number must be less than or equal to INT_MAX/1000
*/
#define CFE_PLATFORM_EVS_MAX_APP_EVENT_BURST 16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this feature enabled by default?

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jul 28, 2022
@skliper skliper added this to the Draco milestone Jul 28, 2022
@skliper
Copy link
Contributor Author

skliper commented Jul 28, 2022

@jhnphm - this is planned for CCB on 8/3. Could you review the recent minor changes? Thanks for putting this together!

Copy link

@jhnphm jhnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting the following changes to make the test code more robust against adjustments to CFE_PLATFORM_EVS_APP_EVENTS_PER_SEC

modules/cfe_testcase/src/evs_send_test.c Show resolved Hide resolved
modules/evs/ut-coverage/evs_UT.c Show resolved Hide resolved
modules/evs/ut-coverage/evs_UT.c Show resolved Hide resolved
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Aug 3, 2022
@skliper skliper marked this pull request as ready for review August 3, 2022 20:43
dzbaker added a commit to nasa/cFS that referenced this pull request Aug 4, 2022
*Combines:*

cfe v7.0.0-rc4+dev157
osal v6.0.0-rc4+dev103

*Includes*
- nasa/cFE#2129, use correct loop var in add_cfe_app_dependency
- nasa/cFE#2117, Automatic suppression of flooding events
- nasa/cFE#2126, Remove stray TODO in UT
- nasa/osal#1274, Remove stray terminators
- nasa/osal#1276, Add RTEMS timebase callback wrapper

Co-authored by: Joseph Hickey  <[email protected]>
Co-authored by: Jacob Hageman  <[email protected]>
Co-authored by: Jose Martinez Pedraza <[email protected]>
@dzbaker dzbaker mentioned this pull request Aug 4, 2022
2 tasks
@dzbaker dzbaker merged commit 946ec31 into nasa:main Aug 4, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Aug 4, 2022
*Combines:*

cfe v7.0.0-rc4+dev157
osal v6.0.0-rc4+dev103

*Includes*
- nasa/cFE#2129, use correct loop var in add_cfe_app_dependency
- nasa/cFE#2117, Automatic suppression of flooding events
- nasa/cFE#2126, Remove stray TODO in UT
- nasa/osal#1274, Remove stray terminators
- nasa/osal#1276, Add RTEMS timebase callback wrapper

Co-authored by: Joseph Hickey  <[email protected]>
Co-authored by: Jacob Hageman  <[email protected]>
Co-authored by: Jose Martinez Pedraza <[email protected]>
@skliper skliper deleted the fix2095-auto_event_suppression branch September 1, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB draco-rc3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic suppression of flooding events
5 participants