Fix #2110, Add CFE_ES_StatusToString and CFE_STATUS_C #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
force-pushed
the
fix2110-add_statustostring
branch
2 times, most recently
from
f7785db
to
87bde9e
Compare
skliper
added
the
CCB:Ready
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| void TestStatusToString(void) | ||
| { | ||
| /* NULL test */ | ||
| UtAssert_ADDRESS_EQ(CFE_ES_StatusToString(CFE_SUCCESS, NULL), NULL); |
Check warning
Code scanning / CodeQL-coding-standard
Unchecked return value
| char expected[CFE_STATUS_STRING_LENGTH + 1]; | ||
|
|
||
| /* Used oversized string to test for truncation */ | ||
| snprintf(expected, sizeof(expected), "0x%08x", (unsigned int)status); |
Check warning
Code scanning / CodeQL-coding-standard
Unchecked return value
| snprintf(expected, sizeof(expected), "0x%08x", (unsigned int)status); | ||
| rtn_addr = CFE_ES_StatusToString(status, &status_string); | ||
| UtAssert_ADDRESS_EQ(rtn_addr, &status_string); | ||
| UtAssert_STRINGBUF_EQ(status_string, sizeof(status_string), expected, sizeof(expected)); |
Check warning
Code scanning / CodeQL-coding-standard
Unchecked return value
| void TestStatusToString(void) | ||
| { | ||
| /* NULL test */ | ||
| UtAssert_ADDRESS_EQ(CFE_ES_StatusToString(CFE_SUCCESS, NULL), NULL); |
Check warning
Code scanning / CodeQL-coding-standard
Unchecked return value
| char expected[CFE_STATUS_STRING_LENGTH + 1]; | ||
|
|
||
| /* Used oversized string to test for truncation */ | ||
| snprintf(expected, sizeof(expected), "0x%08x", (unsigned int)status); |
Check warning
Code scanning / CodeQL-coding-standard
Unchecked return value
| snprintf(expected, sizeof(expected), "0x%08x", (unsigned int)status); | ||
| rtn_addr = CFE_ES_StatusToString(status, &status_string); | ||
| UtAssert_ADDRESS_EQ(rtn_addr, &status_string); | ||
| UtAssert_STRINGBUF_EQ(status_string, sizeof(status_string), expected, sizeof(expected)); |
Check warning
Code scanning / CodeQL-coding-standard
Unchecked return value
skliper
force-pushed
the
fix2110-add_statustostring
branch
from
87bde9e
to
6c8f494
Compare
| /* Used oversized string to test for truncation */ | ||
| snprintf(expected, sizeof(expected), "0x%08x", (unsigned int)status); | ||
| rtn_addr = CFE_ES_StatusToString(status, &status_string); | ||
| UtAssert_ADDRESS_EQ(rtn_addr, status_string); |
Check warning
Code scanning / CodeQL-coding-standard
Unchecked return value
|
|
||
| if (status_string != NULL) | ||
| { | ||
| snprintf(*status_string, sizeof(*status_string), "0x%08x", (unsigned int)status); |
Check warning
Code scanning / CodeQL-coding-standard
Unchecked return value
|
CCB:2022-06-08 APPROVED |
astrogeco
added
CCB:Approved
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 10, 2022
nasa/cFE#2113, Add CFE_ES_StatusToString and CFE_STATUS_C nasa/cFE#2115, Add macro for initializing command header
2 tasks
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 20, 2022
nasa/cFE#2119, Endian macro mask before shift to avoid shift overflow warning nasa/cFE#2115, Add macro for initializing command header nasa/cFE#2113, Add CFE_ES_StatusToString and CFE_STATUS_C
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 20, 2022
nasa/cFE#2119, Endian macro mask before shift to avoid shift overflow warning nasa/cFE#2115, Add macro for initializing command header nasa/cFE#2113, Add CFE_ES_StatusToString and CFE_STATUS_C
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 21, 2022
nasa/cFE#2119, Endian macro mask before shift to avoid shift overflow warning nasa/cFE#2115, Add macro for initializing command header nasa/cFE#2113, Add CFE_ES_StatusToString and CFE_STATUS_C
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 22, 2022
*Combines:* cFE v7.0.0-rc4+dev143 osal osal v6.0.0-rc4+dev87 psp v1.6.0-rc4+dev ci_lab v2.5.0-rc4+dev22 to_lab v2.5.0-rc4+dev21 sample_app v1.3.0-rc4+dev21 **Includes:** - nasa/cFE#2119, Endian macro mask before shift to avoid shift overflow warning - nasa/cFE#2115, Add macro for initializing command header *Add StatusToString API* - nasa/osal#1259, Add OS_StatusToString API - nasa/PSP#347, Add CFE_PSP_StatusToString and CFE_PSP_STATUS_C - nasa/cFE#2113, Add CFE_ES_StatusToString and CFE_STATUS_C *Remove registration of empty EVS filters* - nasa/ci_lab#111, Remove registration of empty EVS filters - nasa/to_lab#122, Remove registration of empty EVS filters - nasa/sample_app#175, Remove registration of empty event filters
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 22, 2022
*Combines:* cFE v7.0.0-rc4+dev143 osal osal v6.0.0-rc4+dev87 psp v1.6.0-rc4+dev ci_lab v2.5.0-rc4+dev22 to_lab v2.5.0-rc4+dev21 sample_app v1.3.0-rc4+dev21 **Includes:** - nasa/cFE#2119, Endian macro mask before shift to avoid shift overflow warning - nasa/cFE#2115, Add macro for initializing command header *Add StatusToString API* - nasa/osal#1259, Add OS_StatusToString API - nasa/PSP#347, Add CFE_PSP_StatusToString and CFE_PSP_STATUS_C - nasa/cFE#2113, Add CFE_ES_StatusToString and CFE_STATUS_C *Remove registration of empty EVS filters* - nasa/ci_lab#111, Remove registration of empty EVS filters - nasa/to_lab#122, Remove registration of empty EVS filters - nasa/sample_app#175, Remove registration of empty event filters Co-authored-by: Jacob Hageman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Adds CFE_ES_StatusToString and CFE_STATUS_C
Testing performed
CI (coverage tests and app testcase functional)
Expected behavior changes
None, just adds useful APIs for future cleanup
System(s) tested on
CI
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
None