SB missing branch coverage in CFE_SB_DeletePipeFull, CFE_SB_SubscribeFull, CFE_SB_UnsubscribeFull: PendingEventID != 0 when status == CFE_SUCCESS

[skliper]

Is your feature request related to a problem? Please describe.
PendingEventID is always set, so can't hit false case:

     447         [ +  - ]:          3 :     else if (PendingEventID != 0)
     448                 :            :     {
     449                 :          3 :         CFE_SB_Global.HKTlmMsg.Payload.CreatePipeErrorCounter++;
     450                 :            :     }

here:

cFE/modules/sb/fsw/src/cfe_sb_api.c

Lines 447 to 450 in 5e41330

	else if (PendingEventID != 0)
	{
	CFE_SB_Global.HKTlmMsg.Payload.CreatePipeErrorCounter++;
	}

Same pattern in CFE_SB_SubscribeFull (although inverted):

    1115         [ +  - ]:        438 :     else if (Status == CFE_SUCCESS)
    1116                 :            :     {
    1117                 :            :         /* If no other event pending, send a debug event indicating success */
    1118                 :        876 :         CFE_EVS_SendEventWithAppID(CFE_SB_SUBSCRIPTION_RCVD_EID, CFE_EVS_EventType_DEBUG, CFE_SB_Global.AppId,
    1119                 :            :                                    "Subscription Rcvd:MsgId 0x%x on PipeId %lu,app %s",
    1120                 :        438 :                                    (unsigned int)CFE_SB_MsgIdToValue(MsgId), CFE_RESOURCEID_TO_ULONG(PipeId),
    1121                 :            :                                    CFE_SB_GetAppTskName(TskId, FullName));
    1122                 :            :     }

here:

cFE/modules/sb/fsw/src/cfe_sb_api.c

Lines 1115 to 1122 in 5e41330

	else if (Status == CFE_SUCCESS)
	{
	/* If no other event pending, send a debug event indicating success */
	CFE_EVS_SendEventWithAppID(CFE_SB_SUBSCRIPTION_RCVD_EID, CFE_EVS_EventType_DEBUG, CFE_SB_Global.AppId,
	"Subscription Rcvd:MsgId 0x%x on PipeId %lu,app %s",
	(unsigned int)CFE_SB_MsgIdToValue(MsgId), CFE_RESOURCEID_TO_ULONG(PipeId),
	CFE_SB_GetAppTskName(TskId, FullName));
	}

Again in CFE_SB_UnsubscribeFull:

    1310         [ +  - ]:         10 :     else if (Status == CFE_SUCCESS)
    1311                 :            :     {
    1312                 :            :         /* if no other event pending, send a debug event for successful unsubscribe */
    1313                 :         20 :         CFE_EVS_SendEventWithAppID(CFE_SB_SUBSCRIPTION_REMOVED_EID, CFE_EVS_EventType_DEBUG, CFE_SB_Global.AppId,
    1314                 :            :                                    "Subscription Removed:Msg 0x%x on pipe %lu,app %s",
    1315                 :         10 :                                    (unsigned int)CFE_SB_MsgIdToValue(MsgId), CFE_RESOURCEID_TO_ULONG(PipeId),
    1316                 :            :                                    CFE_SB_GetAppTskName(TskId, FullName));
    1317                 :            :     }

here:

cFE/modules/sb/fsw/src/cfe_sb_api.c

Lines 1310 to 1317 in 5e41330

	else if (Status == CFE_SUCCESS)
	{
	/* if no other event pending, send a debug event for successful unsubscribe */
	CFE_EVS_SendEventWithAppID(CFE_SB_SUBSCRIPTION_REMOVED_EID, CFE_EVS_EventType_DEBUG, CFE_SB_Global.AppId,
	"Subscription Removed:Msg 0x%x on pipe %lu,app %s",
	(unsigned int)CFE_SB_MsgIdToValue(MsgId), CFE_RESOURCEID_TO_ULONG(PipeId),
	CFE_SB_GetAppTskName(TskId, FullName));
	}

Describe the solution you'd like
Consider just else? Anything that isn't a SUCCESS should increment the error counter.

Describe alternatives you've considered
None.

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

[avan989]

Code coverage is not possible. If Status != CFE_SUCCESS then PendingEventID != 0 (Always set). Recommend just following @skliper solution and use an if/else statement.
This would:

1. make the branch possible
2. make it consistence with how the other function implements this part of the code.