Unsafe macros, investigate conversion into Inline functions

[skliper]

Some places in CFE -- notably, in ccsds.h -- there are macros
that do things like this:

{{{
#define CCSDS_WR_APID(phdr,value)
( (phdr).foo[0] = (value >> 8),
(phdr).foo[1] = (value & 0xFF) )
}}}

This means that if "value" is an expression, odd things happen
when the macro is expanded. This appears in many places in ccsds.h
and we need to do a scan of other headers as well.

It needs to be:
{{{
#define CCSDS_WR_APID(phdr,value)
( (phdr).foo[0] = ((value) >> 8),
(phdr).foo[1] = ((value) & 0xFF) )
}}}
This change needs to happen for all the places where a macro
parameter is an operand in an experession, and does not yet
have parens around it.

UPDATE 2017-10-27: CCB recommends that in many cases we would
benefit from changing these macros into C99 "inline" functions,
so this ticket is being hijacked!

[skliper]

Imported from trac issue 141. Created by glimes on 2016-03-08T13:45:59, last modified: 2019-03-01T16:09:57

[skliper]

Trac comment by glimes on 2016-10-18 15:00:28:

redispatching these tickets to clear my name from the "owner" field,
so people willing to work on tickets will not think that I am already
working these issues ;)

[skliper]

Trac comment by glimes on 2016-11-08 14:17:08:

Current crop of cfe-next are all going into CFE 6.6

[skliper]

Trac comment by glimes on 2017-10-27 14:26:50:

CCB recommends that this scrub looking for places where parentheses should be inserted should also be combined with a review for which of these macros should be C99 "inline" functions instead.

See also ticket #248 for the motivation.

[skliper]

Trac comment by cdknight on 2017-10-27 14:27:16:

see also ticket #245 :)

[skliper]

I think this is also a coding standard violation.

[skliper]

Targeting 7.0 along with the rest of the message abstraction refactoring. Better done as a coordinated change with appropriate scoping/abstraction.

[skliper]

Note ccsds.h was cleaned up with #726. Remaining issues split into specific tickets (did a full scrub), see #843 and #845. Closing this general ticket.