You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The stated purpose (copy across different structures with Second/Subsecond fields) really is better avoided by using a common time structure.
Describe the solution you'd like
Remove CFE_TIME_Copy, use CFE_TIME_SysTime_t which enables simple assignment (x = y), or replace with more type-safe/inline function.
Describe alternatives you've considered
None
Additional context
Code review
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered:
IIRC, the intent of doing this as a macro initially was because there were still some cases where a structure which was notCFE_TIME_SysTime_t had a "Seconds" and "Subseconds" field. In this case the non-type-specific aspect of the macro was desirable, as it would work with any struct that had a seconds and subseconds member, not required to be CFE_TIME_SysTime_t.
As long as all internal structs have been updated to CFE_TIME_SysTime_t then this should be doable, but I recall there might be a few cases still remaining of code storing seconds and subseconds without using the CFE_TIME_SysTime_t type.
Is your feature request related to a problem? Please describe.
The stated purpose (copy across different structures with Second/Subsecond fields) really is better avoided by using a common time structure.
Describe the solution you'd like
Remove
CFE_TIME_Copy
, use CFE_TIME_SysTime_t which enables simple assignment (x = y), or replace with more type-safe/inline function.Describe alternatives you've considered
None
Additional context
Code review
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: