Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify acceptable actions on a shared table along with expected patterns and add functional tests #1493

Open
skliper opened this issue May 11, 2021 · 0 comments
Labels
CFS-43 docs This change only affects documentation. unit-test

Comments

@skliper
Copy link
Contributor

skliper commented May 11, 2021

Is your feature request related to a problem? Please describe.
Currently table sharing management requires careful design or restricting the design space to avoid block/priority concerns.

  • There isn't a "read only" way to get a table address to restrict capability for management to a single "owner"
  • Since update/management can be done by any app with shared access, blocking/priority has to be managed
  • Not immediately clear how the locking/sharing is all intended to work together

Describe the solution you'd like
Should clarify the sharing design documentation, there's currently "hints" in the APIs and a very short section in the cFE Application Developer's Guide but there aren't functional tests that actually implement/exercise all the sharing patterns or a full description of how it's intended to work.

  • Clearly describe how unregistering a shared table is expected to work (or not)
    /* Remove the Access Descriptor Link from linked list */
    /* NOTE: If this removes the last access link, then */
    /* memory buffers are set free as well. */
    CFE_TBL_RemoveAccessLink(TblHandle);

Describe alternatives you've considered
Consider additions/simplification to the sharing model like read only access, etc. Need to tie to requirements, funding, use cases, etc and trade against the additional complexity.

Additional context
Code review, see also #1509

Requester Info
Jacob Hageman - NASA/GSFC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CFS-43 docs This change only affects documentation. unit-test
Projects
None yet
Development

No branches or pull requests

1 participant