Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace magic number in CFE_EVS_MAX_PORT_MSG_LENGTH defnition #1434

Open
skliper opened this issue Apr 28, 2021 · 3 comments
Open

Replace magic number in CFE_EVS_MAX_PORT_MSG_LENGTH defnition #1434

skliper opened this issue Apr 28, 2021 · 3 comments
Labels
CFS-41 enhancement

Comments

@skliper
Copy link
Contributor

skliper commented Apr 28, 2021

Is your feature request related to a problem? Please describe.
Magic number used:

cFE/modules/evs/fsw/src/cfe_evs_task.h

Line 63 in 73c338d

#define CFE_EVS_MAX_PORT_MSG_LENGTH (CFE_MISSION_EVS_MAX_MESSAGE_LENGTH + OS_MAX_API_NAME + 30)

Describe the solution you'd like
Use a defined size (this is probably for time)

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC
@thnkslprpt
Copy link
Contributor

@skliper Can the magic number (30) just be replaced with CFE_TIME_PRINTED_STRING_SIZE?

@skliper
Copy link
Contributor Author

skliper commented Jan 16, 2024

My guess is it's probably a little bigger than that due to the other information in the printed event. Example:

EVS Port1 1980-012-14:03:20.65013 66/1/SC 9: SC Initialized. Version 3.1.99.0

It doesn't look like these parts would be accounted for:
EVS port1
66/1
9:

@thnkslprpt
Copy link
Contributor

Note: see #2566 and #2571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CFS-41 enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thnkslprpt @skliper