Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null pointer check to CFE_ES_ReloadApp functional test #1324

Closed
skliper opened this issue Apr 13, 2021 · 3 comments · Fixed by #1722 or #1772
Closed

Add null pointer check to CFE_ES_ReloadApp functional test #1324

skliper opened this issue Apr 13, 2021 · 3 comments · Fixed by #1722 or #1772

Comments

@skliper
Copy link
Contributor

skliper commented Apr 13, 2021

Is your feature request related to a problem? Please describe.
AppFIleName NULL not checked (or tested)

int32 CFE_ES_ReloadApp(CFE_ES_AppId_t AppID, const char *AppFileName)
{
int32 ReturnCode = CFE_SUCCESS;
os_fstat_t FileStatus;
CFE_ES_AppRecord_t *AppRecPtr = CFE_ES_LocateAppRecordByID(AppID);
if (AppRecPtr == NULL)

Describe the solution you'd like
Add a NULL test, add the check (if needed)

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 7.0.0 milestone Apr 13, 2021
@zanzaben
Copy link
Contributor

AppFileName is tested for null inside OS_stat which is the first place to use it.

@skliper
Copy link
Contributor Author

skliper commented May 20, 2021

Switched to unit-test only, since just the functional check is needed for the NULL pointer.

@skliper skliper changed the title Add null pointer check to CFE_ES_ReloadApp Add null pointer check to CFE_ES_ReloadApp functional test May 25, 2021
@zanzaben
Copy link
Contributor

This will be covered by #806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants