Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of an infinite loop in cfe_sb_task.c #117

Closed
skliper opened this issue Sep 30, 2019 · 6 comments
Closed

Correction of an infinite loop in cfe_sb_task.c #117

skliper opened this issue Sep 30, 2019 · 6 comments
Labels
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

In CFE_SB_SendRtgInfo() the case where (pd == NULL) followed by continue will result in an infinite loop.

the proper correction is to replace the continue with a break, so that the loop is exited on an error.

The correction was made in the following changeset, as part of static code analysis changes:

commit: [changeset:59640e0]

@skliper skliper added this to the 6.6.0 milestone Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 86. Created by gdecaruf on 2015-07-27T16:33:33, last modified: 2019-03-05T14:58:28

@skliper skliper self-assigned this Sep 30, 2019
@skliper skliper added the bug label Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by abrown4 on 2016-08-22 14:31:52:

"Infinite loop" in flight code always gets my attention. After reviewing Guy's changeset, there are quite a few casts he inserted but the loop problem may still remain. Needs to be evaluated against the current codebase.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by sstrege on 2016-10-17 18:27:16:

Verified this has been corrected in 6.5. The if (pd == NULL) check was replaced with if (pd != NULL).

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2016-10-18 14:10:41:

CCB inspection 2016-10-18 shows this is fixed in CFE 6.5

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2016-11-08 14:17:08:

Current crop of cfe-next are all going into CFE 6.6

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-03-05 14:58:28:

Milestone renamed

@skliper skliper closed this as completed Sep 30, 2019
@skliper skliper removed their assignment Sep 30, 2019
jphickey pushed a commit that referenced this issue Jan 9, 2020
jphickey pushed a commit that referenced this issue Jan 9, 2020
Fix #117, #119
Reviewed and approved at 2019-12-18 CCB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant