-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correction of an infinite loop in cfe_sb_task.c #117
Comments
Imported from trac issue 86. Created by gdecaruf on 2015-07-27T16:33:33, last modified: 2019-03-05T14:58:28 |
Trac comment by abrown4 on 2016-08-22 14:31:52: "Infinite loop" in flight code always gets my attention. After reviewing Guy's changeset, there are quite a few casts he inserted but the loop problem may still remain. Needs to be evaluated against the current codebase. |
Trac comment by sstrege on 2016-10-17 18:27:16: Verified this has been corrected in 6.5. The if (pd == NULL) check was replaced with if (pd != NULL). |
Trac comment by glimes on 2016-10-18 14:10:41: CCB inspection 2016-10-18 shows this is fixed in CFE 6.5 |
Trac comment by glimes on 2016-11-08 14:17:08: Current crop of cfe-next are all going into CFE 6.6 |
Trac comment by jhageman on 2019-03-05 14:58:28: Milestone renamed |
In CFE_SB_SendRtgInfo() the case where (pd == NULL) followed by continue will result in an infinite loop.
the proper correction is to replace the continue with a break, so that the loop is exited on an error.
The correction was made in the following changeset, as part of static code analysis changes:
commit: [changeset:59640e0]
The text was updated successfully, but these errors were encountered: