-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #142, Standardize command responses #143
base: main
Are you sure you want to change the base?
Fix #142, Standardize command responses #143
Conversation
@@ -702,12 +718,12 @@ | |||
/* */ | |||
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
|
|||
void SC_ManageTable(SC_TableType type, int32 ArrayIndex) | |||
CFE_Status_t SC_ManageTable(SC_TableType type, int32 ArrayIndex) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
@@ -683,17 +694,22 @@ | |||
/* */ | |||
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
|
|||
void SC_ManageAtsTable(int32 ArrayIndex) | |||
CFE_Status_t SC_ManageAtsTable(int32 ArrayIndex) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
@@ -664,17 +670,22 @@ | |||
/* */ | |||
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
|
|||
void SC_ManageRtsTable(int32 ArrayIndex) | |||
CFE_Status_t SC_ManageRtsTable(int32 ArrayIndex) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
@@ -702,12 +718,12 @@ | |||
/* */ | |||
/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
|
|||
void SC_ManageTable(SC_TableType type, int32 ArrayIndex) | |||
CFE_Status_t SC_ManageTable(SC_TableType type, int32 ArrayIndex) |
Check notice
Code scanning / CodeQL-coding-standard
Function too long Note
Checklist
Describe the contribution
SC_RESET_DEB_EID
,SC_DISABLE_RTS_DEB_EID
,SC_ENABLE_RTS_DEB_EID
&SC_CONT_CMD_DEB_EID
toINFORMATION
typeSC_TABLE_MANAGE_INF_EID
) and required logic to theSC_ManageTableCmd
andSC_ManageTable
functions in order to return a success event when no errors were encountered during processing (either from the SC functions or passed through from cFE functions)SC_TABLE_MANAGE_INF_EID
Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
Success event will be issued if no errors are encountered during processing of the
SC_MANAGE_TABLE_CC
command.System(s) tested on
Debian GNU/Linux 12 (bookworm)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt