Fix #113, Fix #123, Symbol naming convention and message conversions #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
force-pushed
the
fix-113-123-symbols
branch
from
cb48699
to
e97dcb5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fsw/src/sc_atsrq.c
Dismissed
| @@ -570,7 +570,7 @@ | |||
| /* | |||
| ** Set the next command time for the ATP | |||
| */ | |||
| SC_AppData.NextCmdTime[SC_ATP] = ListCmdTime; | |||
| SC_AppData.NextCmdTime[SC_Process_ATP] = ListCmdTime; | |||
Check failure
Code scanning / CodeQL-security
Potentially uninitialized local variable High
There was a problem hiding this comment.
Checked this report - it is a false positive - No real chance of it being uninitialized due to the combination of logic prior to this.
Also was pre-existing - not changed by this PR.
jphickey
force-pushed
the
fix-113-123-symbols
branch
2 times, most recently
from
bd37cab
to
9ac3165
Compare
2 tasks
Create enumerations according to the style documented in CFE. Existing symbols are put inside a backward compatibility switch, such that existing table and message definitions should still work.
Rather than taking the address of a sub-member, use the macro provided from the CFE_MSG module to convert from a local container to a CFE_MSG_Messge_t pointer.
jphickey
force-pushed
the
fix-113-123-symbols
branch
from
9ac3165
to
957b10b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
First commit: updates all symbol names to adhere to the naming conventions from CFE. This is basically a search and replace, to make names compliant.
Fixes #113
Second commit: Apply the
CFE_MSG_PTR()macro to do type conversions on messages.Fixes #123
Testing performed
Build and run SC and all tests
Expected behavior changes
None
System(s) tested on
Debian
Additional context
These two fixes are combined into a single PR as the second one is affected by the name changes in the first one. These would conflict if done in separate PRs.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.