New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in `Pack_Time` (fsw/src/sbn_pack.c): Use of uninitialized variable #53

Open

Nodraak opened this issue Jan 17, 2024 · 0 comments

Nodraak commented Jan 17, 2024 •

edited

Loading

Hi,

Bug: in https://github.com/nasa/SBN/blob/main/fsw/src/sbn_pack.c#L55, D is uninitialized and packed into PackPtr

Solution: the return value from OS_TimeAssembleFromMicroseconds() should be assigned to D.

Root cause: this change introduced the bug.

This bug was found with CPPcheck: Line 24: Uninitialized variable: DataBuf

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment