change * to ** in cfe_psp_memory.c

[skliper]

For improved efficiency consider changing 1st argument to be a double pointer of type void, and not a single pointer of type void. Then a straight assignment can be used in place of memcpy(used to copy 4 bytes). This will be an API change.

{{{
int32 CFE_PSP_WriteToCDS(void *PtrToDataToWrite, uint32 CDSOffset, uint32 NumBytes)
}}}
to
{{{
int32 CFE_PSP_WriteToCDS(void **PtrToDataToWrite, uint32 CDSOffset, uint32 NumBytes)
}}}
Need to assess this proposed change. Why was it implemented the way it was originally?

[skliper]

Imported from trac issue 40. Created by sduran on 2015-09-03T11:25:53, last modified: 2019-08-14T14:13:14

[skliper]

Trac comment by jhageman on 2019-08-13 10:24:25:

Possible improved efficiency based on special case (4 byte copy) likely isn't enough to justify an API change. Consider writing a unique function (CFE_PSP_WriteToCDS_32bit or similar) if needed and benchmark against current implementation to justify use case.

[skliper]

Memcpy is the general implementation to support variable size. Won't fix.