Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "CFE_PSP_GetVersion()" function #252

Closed
jphickey opened this issue Feb 18, 2021 · 2 comments
Closed

Implement "CFE_PSP_GetVersion()" function #252

jphickey opened this issue Feb 18, 2021 · 2 comments
Assignees
Labels
duplicate This issue or pull request already exists

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As described in nasa/osal#821 it is better to acquire version info strings/values at runtime rather than via a macro, because of where and how it will get evaluated.

PSP is actually in better shape than OSAL/CFE because CFE_PSP_VERSION currently refers to a string which is stored in GLOBAL_PSP_CONFIGDATA. But still, it would be better and more conventional to get this value via an API call.

Describe the solution you'd like
Implement CFE_PSP_GetVersion() and related APIs to get the various version strings.

Describe alternatives you've considered
Leave in global object.

Additional context
See details in nasa/osal#821

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Feb 18, 2021
@jphickey jphickey added the enhancement New feature or request label Feb 18, 2021
@skliper skliper added this to the 1.6.0 milestone Feb 18, 2021
@jphickey
Copy link
Contributor Author

Implemented in #256, this is a duplicate

@skliper
Copy link
Contributor

skliper commented Mar 24, 2021

Duplicate issue is #257

@skliper skliper removed this from the 1.6.0 milestone Mar 24, 2021
@skliper skliper added duplicate This issue or pull request already exists and removed enhancement New feature or request labels Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants