Fix #14, Refactor LC_SampleAPs to remove extraneous if statement #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
LC_SampleAPs()
has been refactored to remove the extraneousif
statement.StartIndex == EndIndex
, thefor
loop will only run once (i.e. the same as before).Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
Intent of the code remains basically unchanged, although the logic has changed slightly.
Main change is that
CurrentAPState
is checked as valid before any sampling of action points, whereas previously this was only checked in the single action point sample condition - i.e.if (StartIndex == EndIndex)
Contributor Info
Avi @thnkslprpt