Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #111, Update LC_RESET_DBG_EID to be informational #112

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

avan989
Copy link

@avan989 avan989 commented Jun 3, 2024

Fix #111, update LC_RESET_DBG_EID to be informational event instead of debug

Checklist (Please check before submitting)

Describe the contribution
A clear and concise description of what the contribution is.

  • Include explicitly what issue it addresses [e.g. Fixes #X]

Fixes #111, update reset command events to be infomational instead of debug

Testing performed
Steps taken to test the contribution:

  1. make SIMULATION=native prep

  2. Make install

  3. Verify it works

  4. Make SIMULATION=native ENABLE_UNIT_TESTS=true prep

  5. make

  6. make test

  7. make lcov

  8. Verify all test still pass/lcov is 100%

Expected behavior changes
No impact to behavior

System(s) tested on

  • Hardware: [e.g. PC, SP0, MCP750]
  • OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
  • Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

  • Note CLA's apply to software contributions.
    Anh Van, GSFC

@avan989 avan989 force-pushed the fix-111-standardization-cmd-rsp branch from c406a4c to 1e9dff1 Compare June 21, 2024 09:51
@avan989
Copy link
Author

avan989 commented Jun 21, 2024

update to fix documentation issue. @dzbaker Can you rerun the workflow?

@dzbaker
Copy link
Contributor

dzbaker commented Jun 27, 2024

CCB 27 June 2024: Will review at CCB once Event ID Naming PRs have been merged.

Fix nasa#111, update LC_RESET_DBG_EID to be informational event instead of
debug
@avan989 avan989 force-pushed the fix-111-standardization-cmd-rsp branch from 1e9dff1 to a7b4f47 Compare August 5, 2024 12:30
@dzbaker dzbaker merged commit b566cd5 into nasa:main Aug 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardization of Command Responses
3 participants