Fix #26, Apply consistent Event ID names to common events #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havencarlson
approved these changes
Oct 28, 2022
thnkslprpt
force-pushed
the
fix-26-apply-consistent-event-id-names
branch
from
890e59c
to
bee2f62
Compare
|
@thnkslprpt Can you fix the merge conflicts for this pull request? |
thnkslprpt
force-pushed
the
fix-26-apply-consistent-event-id-names
branch
from
bee2f62
to
7d51d63
Compare
thnkslprpt
force-pushed
the
fix-26-apply-consistent-event-id-names
branch
from
7d51d63
to
1f7715a
Compare
I think that's all cleared up now mate. |
dzbaker
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Testing performed
Only GitHub CI actions.
Expected behavior changes
No impact on code behavior (no logic changes).
Consistent Event ID names for the events which are common to all/most cFS components and apps will improve consistency and ease make code review/debugging easier.
Contributor Info
Avi Weiss @thnkslprpt