Fix #57, Remove redundant/inconsistent comments (/* end of function */, /* end if */ etc.) and clean up empty lines. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thnkslprpt CCB 13 October 2022: Approved pending squash of commits and ensuring that commit message follows format and internal review of changes. |
thnkslprpt
force-pushed
the
fix-57-comment-and-empty-line-cleanup
branch
from
79bac48
to
58f99bf
Compare
That's done now. |
havencarlson
requested changes
Oct 18, 2022
thnkslprpt
force-pushed
the
fix-57-comment-and-empty-line-cleanup
branch
from
58f99bf
to
8f6e35f
Compare
I added those now Haven. |
havencarlson
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #57
Removes redundant and inconsistent comments (e.g.
/* end of function */,/* end if */, function name in function header comments).There were also a few cases of unnecessary empty lines (e.g. on the last line before the closing brace of a function) and also missing empty lines (e.g. between functions) which were corrected. Some of these empty lines trigger the CI format checks.
I've left the commits separated for now to make life easier for whoever reviews this. I can squash them if/when this is ready for merge.
Testing performed
None (comment and whitespace changes only).
Expected behavior changes
No impact on behavior.
These updates will reduce clutter and inconsistency in the code, improving readability.
Contributor Info
@thnkslprpt