Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #34 #37 #43 #44, UT cleanup, remove unreachable code, initialize FileMode on OS_stat failure #45

Merged
merged 4 commits into from
Aug 3, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Aug 1, 2022

Checklist (Please check before submitting)

Describe the contribution

Testing performed
CI

Expected behavior changes
Will now initialize FileMode on OS_stat failure (won't write uninitialized data)

System(s) tested on
CI

Additional context
Can break up if needed, but easier to submit together since they resolve related coverage and UT issues.

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the Draco milestone Aug 1, 2022
@dzbaker dzbaker merged commit c06c101 into nasa:main Aug 3, 2022
@skliper skliper deleted the fix37-random_ut branch September 19, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment