Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #86, Removes extraneous boolean logic in concat command #108

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

chillfig
Copy link
Contributor

@chillfig chillfig commented Jun 7, 2023

Checklist (Please check before submitting)

Describe the contribution

Testing performed

  • lcov
  • build
  • cert_testbed cFE_EVS_ConcatFilesCmd.json functional test successful

Expected behavior changes
No impact to behavior

System(s) tested on

  • OS: Ubuntu 22.04

Additional context
Could be argued that the concat function is more readable as-is, but this way, the NASA recommendation of 15 max cyclomatic complexity per function is satisfied.

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage Systems

@chillfig chillfig self-assigned this Jun 7, 2023
@dzbaker dzbaker merged commit 9a578cb into nasa:main Jun 8, 2023
@dmknutsen dmknutsen added this to the Equuleus milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FM_ChildConcatCmd - cyclomatic complexity of 17
3 participants