Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #106, Consolidate HK variables that are duplicated in the global struct #107

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

Expected behavior changes
No change to behavior other than storage location of the variables as outlined above.

Simpler pattern, reduces duplication and eases future maintenance.

Contributor Info
Avi Weiss @thnkslprpt

@dzbaker dzbaker requested review from chillfig and jphickey June 8, 2023 18:20
@thnkslprpt thnkslprpt force-pushed the fix-106-consolidate-common-members-of-hk-and-global-structs branch from 85a64a7 to 03da887 Compare June 29, 2023 03:39
@thnkslprpt thnkslprpt force-pushed the fix-106-consolidate-common-members-of-hk-and-global-structs branch from 03da887 to c05eee0 Compare June 29, 2023 03:45
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, but I'm not sure we want to do this. In general we are trying to get away from using telemetry data as real-time state info. Its because the former needs to be formatted in a certain way for sending across the network where the latter should be in a format where it is optimized for real-time access. So while the logical data might overlap, it is generally a good idea to separate this.

@thnkslprpt thnkslprpt closed this Apr 19, 2024
@thnkslprpt thnkslprpt deleted the fix-106-consolidate-common-members-of-hk-and-global-structs branch April 25, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HK struct members that are duplicated in the Global struct could be consolidated
2 participants