Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #56, Update out-of-sync function paramater names and correct typos #57

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix #56, Update out-of-sync function paramater names and correct typos #57

merged 1 commit into from
Nov 16, 2023

Conversation

thnkslprpt
Copy link
Contributor

Describe the contribution

  • Fixes Update out-of-sync function prototype/implementation parameter names #56
    • Updates parameter names in CFE_MissionLib_Python_Interface_GetFromIntfName() and CFE_MissionLib_Python_Topic_GetFromTopicName() implementations to match the prototypes
    • Fixes typo in SEDS_PREPROCESS_ENVIORNMENT const variable (environment is misspelled)
    • Fix up general comment typos along the way

Testing performed
None

Expected behavior changes
No change to behavior.

Contributor Info
Avi Weiss @thnkslprpt

@dzbaker dzbaker requested a review from jphickey June 8, 2023 18:17
jphickey
jphickey approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for finding and fixing all of these. Lots of typos in there.

@jphickey jphickey added the CCB:Ready Pull request is ready for CCB discussion label Sep 29, 2023
@jphickey jphickey merged commit 4b866f1 into nasa:main Nov 16, 2023
@jphickey jphickey added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for CCB discussion labels Nov 16, 2023
@thnkslprpt thnkslprpt deleted the fix-56-update-out-of-sync-function-prototype-paramater-names branch November 16, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jphickey jphickey jphickey approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update out-of-sync function prototype/implementation parameter names
2 participants
@thnkslprpt @jphickey