Fix #25, Remove misleading/unnecessary event text #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dzbaker @dmknutsen - this change is fine, but what happened to coverage? Did something sneak by? |
@skliper Thanks for catching that! We found where we lost the coverage and are working on tests to get back to full coverage. |
thnkslprpt
force-pushed
the
fix-25-remove-misleading-unnecessary-event-text
branch
from
05fef4b
to
f2b4461
Compare
jphickey
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #25
Unnecessary/misleading test (
"desc text = OK") has been removed from event messages inDS_TableVerifyFilter()andDS_TableVerifyDestFile().Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully -
except coverage rates which is being addressed in separate issue #65Expected behavior changes
No impact on logic.
"desc text = OK"will no longer be printed in these 2 event messages.Contributor Info
Avi Weiss @thnkslprpt