Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #111: Use correct length filename for too large test #112

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

irowebbn
Copy link
Contributor

@irowebbn irowebbn commented Jun 12, 2023

Checklist (Please check before submitting)

Describe the contribution
Fixes #111

Testing performed
See reproduction steps from linked issue

Expected behavior changes
Tests should pass if OSAL_CONFIG_MAX_PATH_LEN is increased

System(s) tested on

  • Hardware: Intel Xeon CPU E5-2687W v4 @ 3.00GHz
  • OS: CentOS 7
  • Versions: trunk DS, cFE Draco rc-3

Additional context
Add any other context about the contribution here.
Related cFE issue: nasa/cFE#2372

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)
Isaac Rowe, NASA JSC/Jacobs Technology

@irowebbn irowebbn changed the title Use correct length filename for too large test Fixes #111: Use correct length filename for too large test Jun 20, 2023
@irowebbn irowebbn changed the title Fixes #111: Use correct length filename for too large test Fix #111: Use correct length filename for too large test Jun 20, 2023
@chillfig chillfig self-assigned this Nov 9, 2023
@dzbaker
Copy link
Contributor

dzbaker commented Nov 30, 2023

@irowebbn CCB 30 November 2023: Agreed to provisionally approve. A couple of changes are needed:

  1. DirName should be declared at top of function.
  2. sizeof(char) will always be 1 in C, therefore is not needed.

irowebbn added a commit to irowebbn/DS that referenced this pull request Nov 30, 2023
- Move `DirName` directory to beginning of function
- Remove redundant `sizeof(char)`
@dzbaker dzbaker merged commit f04f6a0 into nasa:main Dec 5, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSAL path length variables cause tests to fail
3 participants