Fix #26, Use CFE_ES_MemAddress_t
instead of cpuaddr
in tables/tlm/cmd structs
#86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
cpuaddr
types in tables/cmd/tlm structs to fixed-sizeCFE_ES_MemAddress_t
Filler32
inCS_Res_EepromMemory_Table_Entry_t
(I assume it was there to align to the 64-bitcpuaddr
which is is longer necessary (unless/untilCFE_ES_MemAddress_t
andCFE_ES_MemOffset_t
are redefined as 64-bits in Default to 64 bit memory address/offset for all IO (cmd/tlm/tbl/binary dumps) cFE#2093. Another option is to just leave it in now for future compatibility with 64-bit alignment.Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Coverage Tests etc.).
Expected behavior changes
Exposed structs will no longer change size based on the definition of
cpuaddr
.Contributor Info
Avi Weiss @thnkslprpt