Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #26, Use CFE_ES_MemAddress_t instead of cpuaddr in tables/tlm/cmd structs #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Jun 11, 2023

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Coverage Tests etc.).

Expected behavior changes
Exposed structs will no longer change size based on the definition of cpuaddr.

Contributor Info
Avi Weiss @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-26-use-fixed-size-types-for-tables-cmd-tlm-structs branch 3 times, most recently from e36d0e6 to 7df1e3d Compare September 5, 2023 03:09
@thnkslprpt thnkslprpt force-pushed the fix-26-use-fixed-size-types-for-tables-cmd-tlm-structs branch from 7df1e3d to e51b7d2 Compare March 23, 2024 11:09
@dzbaker
Copy link
Contributor

dzbaker commented Oct 24, 2024

Reviewed at 24 October CCB: This is a change we would like to make, although with the telemetry/cmd impacts, we are going to hold off on merging this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use fixed size types for addresses and address offsets in tables/tlm/cmd
2 participants