Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #67, Combine consecutive, mutually-exclusive status checks #68

Merged

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Mar 13, 2023

Checklist

Describe the contribution

  • Fixes Combine consecutive, mutually-exclusive status checks #67
    • 3 separate pairs of consecutive, mutually-exclusive status checks combined into if/else constructs.
    • Code changes are in cs_app.c and cs_init.c
    • Some typos corrected as a piggy-back on this PR.
    • Also capitalised EEPROM in all text (was inconsistently capitalised previously).

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
No change to logic.
Single evaluation instead of twice in these if blocks now.

Contributor Info
Avi Weiss @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-67-combine-mutually-exclusive-status-checks branch from b21bea8 to 0512e34 Compare March 14, 2023 01:54
@dzbaker dzbaker merged commit ebd338c into nasa:main Apr 13, 2023
@thnkslprpt thnkslprpt deleted the fix-67-combine-mutually-exclusive-status-checks branch April 13, 2023 20:54
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine consecutive, mutually-exclusive status checks
4 participants