Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirement verification failure #54

Open
dmknutsen opened this issue Oct 28, 2022 · 1 comment
Open

Requirement verification failure #54

dmknutsen opened this issue Oct 28, 2022 · 1 comment
Assignees
Labels
Milestone

Comments

@dmknutsen
Copy link
Contributor

dmknutsen commented Oct 28, 2022

Describe the bug
The following requirements fail verification testing because for each - an event message is sent, but Checksumming is not disabled:

9007.2 (User Memory)
CS shall send an event message and disable Checksumming of the User-Defined Memory, if the state is not one of the following:
a) enabled
b) disabled
c) empty

9007.1 (User Memory)
If the address range for any of the User-Defined Memory is Invalid, CS shall send an event message and disable User-Defined Memory Checksumming

9006.1 (Tables)
CS shall send an event message and disable Table Checksumming, if the state is not one of the following:
a) enabled
b) disabled
c) empty

9005.1 (Apps)
CS shall send an event message and disable Application code segment Checksumming, if the state is not one of the following:
a) enabled
b) disabled
c) empty

9003.2 (Non-Volatile)
CS shall send an event message and disable Non-volatile Checksumming, if the state is not one of the following:
a) enabled
b) disabled
c) empty

9003.1 (Non-Volatile)
If the address range for any of the Non-volatile segments is Invalid, CS shall send an event message and disable Non-volatile Checksumming

Expected behavior
Checksumming will need to be disabled in each case or the requirements will need to be updated

Code snips
Example from cs_table_processing.c:
if (Result != CS_TABLE_ERROR)
{
CFE_EVS_SendEvent (CS_VAL_EEPROM_STATE_ERR_EID,
CFE_EVS_EventType_ERROR,
"Eeprom Table Validate: Illegal State Field (0x%04X) found in Entry ID %d",
(unsigned short)StateField,
(int)OuterLoop);
Result = CS_TABLE_ERROR;
}

Reporter Info
Dan Knutsen
NASA Goddard

@dmknutsen dmknutsen added the bug label Oct 28, 2022
@dmknutsen dmknutsen added this to the Equuleus milestone Sep 7, 2023
@havencarlson
Copy link
Contributor

I believe checksumming is being disabled in CS_InitAllTables()

Example:

CS/fsw/src/cs_init.c

Lines 111 to 116 in d9c1034

if (ResultInit != CFE_SUCCESS)
{
CS_AppData.HkPacket.Payload.EepromCSState = CS_STATE_DISABLED;
CFE_EVS_SendEvent(CS_INIT_EEPROM_ERR_EID, CFE_EVS_EventType_ERROR,
"Table initialization failed for EEPROM: 0x%08X", (unsigned int)ResultInit);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants