Fix #52, Apply consistent Event ID names to common events #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillfig
requested changes
Nov 1, 2022
fsw/src/cs_events.h
Outdated
| @@ -60,7 +60,7 @@ | |||
| * | |||
| * This event message is issued when a reset counters command has been received. | |||
| */ | |||
| #define CS_RESET_DBG_EID 3 | |||
| #define CS_RESET_INF_EID 3 | |||
There was a problem hiding this comment.
Why does this event name change from using DBG to INF?
Line 57 may need an update to indicate this event is informational type.
There was a problem hiding this comment.
Should be updated now Justin.
thnkslprpt
force-pushed
the
fix-52-apply-consistent-event-id-names
branch
from
d3335ce
to
6ab5451
Compare
Cheers mate. |
chillfig
requested changes
Nov 1, 2022
thnkslprpt
force-pushed
the
fix-52-apply-consistent-event-id-names
branch
from
6ab5451
to
7bdfb22
Compare
chillfig
approved these changes
Nov 1, 2022
|
CCB:2023.03.09: Putting on hold until naming conventions for event, etc are merged. |
thnkslprpt
force-pushed
the
fix-52-apply-consistent-event-id-names
branch
from
7bdfb22
to
57d7b56
Compare
thnkslprpt
force-pushed
the
fix-52-apply-consistent-event-id-names
branch
from
57d7b56
to
a5f0cf4
Compare
thnkslprpt
force-pushed
the
fix-52-apply-consistent-event-id-names
branch
2 times, most recently
from
de94f05
to
c31a276
Compare
thnkslprpt
force-pushed
the
fix-52-apply-consistent-event-id-names
branch
from
c31a276
to
ed928b0
Compare
|
It looks like in the recent rebase, some updates got merged incorrectly, causing the workflow failure |
jphickey
force-pushed
the
fix-52-apply-consistent-event-id-names
branch
from
ed928b0
to
ba3051c
Compare
|
Rebased to latest mainline and manually fixed up some merge overlaps re: payload member. Workflows now pass and this should be good to go. |
|
Thanks Joe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Testing performed
Only GitHub CI actions.
Expected behavior changes
No impact on code behavior (no logic changes).
Consistent Event ID names for the events which are common to all/most cFS components and apps will improve consistency and ease make code review/debugging easier.
Contributor Info
Avi Weiss @thnkslprpt