Fix #44, CS_RecomputeAppChildTask wrong function key #45
Conversation
There was a problem hiding this comment.
The assert errors produced from 'CS_RecomputeAppChildTask_Test_DefEntryId()` shown in #44 do not align with the unit test coverage results ran on main branch of nasa/cs. However, the change suggested is appropriate and maintains 100% unit coverage in nasa/cs. This pull requests requires pull request description and a contributor license agreement from the contributor before merging.
|
@chillfig Thanks for the help. I am waiting to hear back from my employer about permission for the CLA since this was discovered as part of my official duties. |
|
@irowebbn CCB 13 October 2022: Pending CLA and PR description/linked issue. |
|
26 January 2023: Ignoring while waiting on CLA. |
Tests failing on nasa/CS main branch as well now (see https://github.com/thnkslprpt/CS/actions/runs/4333025360/jobs/7565890664#step:11:3742). I will submit a PR (given that this one has been stuck for 5 months) with the change identified by @irowebbn fixing the tests so that it doesn't start holding up other PRs. |
|
Superceded by #65 |
No description provided.