ci: Add ruff to dev

[dangotbanned]

Following (#2803), two (PD002) ignores are no longer needed

Previous

narwhals/narwhals/_pandas_like/group_by.py

Line 217 in 54bf3d3

result.reset_index(inplace=True) # noqa: PD002

narwhals/narwhals/_pandas_like/group_by.py

Line 264 in 54bf3d3

result_complex.reset_index(inplace=True) # noqa: PD002

main

narwhals/narwhals/_pandas_like/group_by.py

Line 217 in 8afbeec

result.reset_index(inplace=True)

narwhals/narwhals/_pandas_like/group_by.py

Line 264 in 8afbeec

result_complex.reset_index(inplace=True)

Notes

pre-commit autoupdate enforces the latest version of ruff in ci, but we don't have anything syncing this with pyproject.toml.
A solution for now is just to leave it unpinned, so at least it'll install the latest when updating a local venv

Those lines have moved in (#2680), and still require the (PD002) ignore - so I think the removal is related to ruff's type inference changing under-the-hood

narwhals/narwhals/_pandas_like/group_by.py

Line 331 in 46282e8

df.reset_index(inplace=True) # noqa: PD002

[MarcoGorelli]

thanks - not sure tbh, i think we should rather just have it in pre-commit, and if anyone doesn't want to use pre-commit then it's on them to self-manage

[dangotbanned]

thanks - not sure tbh, i think we should rather just have it in pre-commit, and if anyone doesn't want to use pre-commit then it's on them to self-manage

I'm using pre-commit and by not having ruff declared in our dependencies - VSCode will default to what is used in https://marketplace.visualstudio.com/items?itemName=charliermarsh.ruff

The extension ships with ruff==0.12.0.

So on unrelated PRs, as soon as I merge (#2803) I now get warnings from a problem introduced in 0.12.2.
If I decide to self-manage, I now have to keep everything in sync with pre-commit.
If I don't want to self-manage, I can't get feedback in VSCode and have to rely on pre-commit which is much slower.

Is there some cost to adding it to dev that I'm missing?
Just from sampling our upstream and downstream dependencies, this is very common:

• https://github.com/pola-rs/polars/blob/f45e937f80953f45cc84c922847a683299f59e67/py-polars/requirements-lint.txt#L2
• https://github.com/vega/altair/blob/d1f4a1ef89006e5f6752ef1f6df4b7a509336fba/pyproject.toml#L72
• https://github.com/marimo-team/marimo/blob/7d09872756235da1593342d6e7c5d15a1dbc0016/pyproject.toml#L114
• https://github.com/Nixtla/hierarchicalforecast/blob/434c411c475e8b5ce852943e018e77e16c198f05/settings.ini#L19
• https://github.com/Quantco/metalearners/blob/ce013726ff283364e4db170603c39d4bfbce13c3/pixi.toml#L54
• https://github.com/panel-extensions/panel-graphic-walker/blob/26415e49d05d04c34782eb034f8d5163208fc896/pyproject.toml#L57
• https://github.com/plotly/plotly.py/blob/6d864c42d91e2c625fbf1ea6d7dbddeecc7f51ef/pyproject.toml#L48
• https://github.com/posit-dev/pointblank/blob/29fe77a31be2144fb8c1dc405ca7694090798024/pyproject.toml#L99
• https://github.com/vincentarelbundock/pymarginaleffects/blob/2ec19403f7b8c04d8b97a73fcc8ad42e9b523681/pyproject.toml#L42
• https://github.com/rio-labs/rio/blob/778487c34403bcc17f989a4c6777bd72d16af93d/pyproject.toml#L109
• https://github.com/koaning/scikit-lego/blob/a39e6d7a33a9c6fdd16faa2b3a23aa2dc58ab0e7/pyproject.toml#L84

I just want to be able to auto-fix stuff in my IDE, without needing to concern myself with manually syncing dependencies 😅

[MarcoGorelli]

you'd still need to keep it in sync if there's a new ruff release before the pre-commit autoupdate job runs

but, sure, if it eases dev workflow, no objections

[dangotbanned]

#2811 (review)

Thanks for understanding @MarcoGorelli!

If this comes up again as an issue, we could always try out dependabot

• Support updating uv.lock dependabot/dependabot-core#10478
• https://github.blog/changelog/2025-03-13-dependabot-version-updates-now-support-uv-in-general-availability/