Skip to content

Commit 6c35f86

Browse files
jleverenznapcs
authored andcommitted
Update mocha version & fix should.be API use error.
A mocha defect silently ignored this for the previous package-lock mocha version (5.0.1). See the following issue and changelog: mochajs/mocha#3226 https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#502--2018-03-05 Test should have failed in all cases, but false passing occured with older mocha versions.
1 parent 61d124c commit 6c35f86

File tree

3 files changed

+32
-31
lines changed

3 files changed

+32
-31
lines changed

package-lock.json

+30-29
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
},
3030
"devDependencies": {
3131
"coffee-script": ">= 1.8.0",
32-
"mocha": "^5.0.1",
32+
"mocha": "^5.2.0",
3333
"request": ">= 2.9.203",
3434
"should": "^13.2.1",
3535
"sinon": "^1.17.4"

test/index.test.coffee

+1-1
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ describe 'livereload server startup', ->
154154
it 'should gracefully handle something running on the same port', (done) ->
155155
new_server = livereload.createServer({debug: true, port: 35729})
156156
new_server.on 'error', (err) ->
157-
err.code.should.be("EADDRINUSE")
157+
err.code.should.be.equal("EADDRINUSE")
158158

159159
done()
160160

0 commit comments

Comments
 (0)