-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wondered why my threshold entries were empty in the settings #294
Comments
Yes. The configuration page was unfortunately broken. Because there was one spelling for the field where you entered the value, and then another name in the config file. So the value in the config file isn't loaded into the configuration page and vice versa, the value entered in the configuration page wasn't save. So unless you manually modified the JSON config file, it wasn't working. |
No problem, I think this can still be done to migrate the settings, as others will not have noticed this problem yet due to issue #247. ;-) |
I started to investigate a migration path, and I wonder if this would work. I would add the correct spelling rather than correcting the spelling. The result is that the old fields and new fields will appear in the config.json file. So I would put this back:
and add this:
Update the usage code to prefer the correct spelling values (ie the ones entered through the UI), ie:
The old data will not appear Configuration UI, but if you do enter a threshold values in the Configuration UI then it will use it. It'll just leave behind the old data - which could be confusing. |
I think this would be confusing if someone has the old settings, which then would be read correctly, but not be displayed in the settings. |
Agree that it would be confusing. I have not yet seen a way to manipulate the config.json. |
Then just drop a small note in the update section, so that users are aware this. ;-) |
You changed the names for the threshold config, see: v3.3.3...master#diff-be1695b1e63a508d59982601f9e1fb7f58247deecb1e427adb77bcad758ae5e5
It was for example "tresholdAirPressure" in plugin version 3.3.2
Since 3.3.3 you corrected the typo and named it "thresholdAirPressure".
This results in empty settings for the threshold sensors.
No big deal but would have been nice to be noticed about this. ;-)
The text was updated successfully, but these errors were encountered: