Log and fail if db init fails

Author: glinton

balance/balance.go

@@ -106,11 +106,11 @@ func SetServices(services []core.Service) error {
 		tab.RenameChain("filter", "portal-old", "portal")
 	}
 	if err == nil && tab != nil {
-		cleanup := func(error) error {
+		cleanup := func(err2 error) error {
 			tab.ClearChain("filter", "portal")
 			tab.DeleteChain("filter", "portal")
 			tab.RenameChain("filter", "portal-old", "portal")
-			return fmt.Errorf("Failed to tab.Insert() - %s", err)
+			return fmt.Errorf("Failed to tab.Insert() - %s", err2)
 		}
 
 		tab.NewChain("filter", "portal")

commands/commands.go

@@ -31,7 +31,7 @@ var (
 
 	Portal = &cobra.Command{
 		Use:               "portal",
-		Short:             "portal - load balancer/proxy",
+		Short:             "load balancer/proxy",
 		Long:              ``,
 		PersistentPreRunE: readConfig,
 		PreRunE:           preFlight,

database/database.go

@@ -46,7 +46,7 @@ func Init() error {
 	}
 	err = Backend.Init()
 	if err != nil {
-		Backend = nil
+		return fmt.Errorf("Failed to init database - %s", err)
 	}
 	return nil
 }

database/scribble.go

@@ -164,6 +164,7 @@ func (s ScribbleDatabase) GetRoutes() ([]core.Route, error) {
 	routes := make([]core.Route, 0, 0)
 	values, err := s.scribbleDb.ReadAll("routes")
 	if err != nil {
+		// todo: need to ensure db doesn't get cleared with new scribble (shared mutex) (previously if err finding .tmp file, db could be dropped)
 		if strings.Contains(err.Error(), "no such file or directory") {
 			// if error is about a missing db, return empty array
 			return routes, nil
@@ -211,6 +212,7 @@ func (s ScribbleDatabase) SetRoute(route core.Route) error {
 
 func (s ScribbleDatabase) DeleteRoute(route core.Route) error {
 	routes, err := s.GetRoutes()
+	// todo: need to ensure db doesn't get cleared with new scribble (shared mutex) (previously if err finding .tmp file, db could be dropped)
 	if err != nil {
 		return err
 	}