Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download data file automatically in high_level_benchmark.py #1619

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

abhisrkckl
Copy link
Contributor

This avoids getting wrong profiling results if the large tim file for J0740+6620 is not present in the directory.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dc40e8b) 68.14% compared to head (e9bf1c7) 68.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1619   +/-   ##
=======================================
  Coverage   68.14%   68.15%           
=======================================
  Files          98       98           
  Lines       22660    22660           
  Branches     3893     3893           
=======================================
+ Hits        15442    15444    +2     
+ Misses       6264     6262    -2     
  Partials      954      954           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlakaplan
Copy link
Contributor

Looks fine. I can merge when you are ready.

@abhisrkckl
Copy link
Contributor Author

Please do so.

@dlakaplan dlakaplan merged commit 458fd07 into nanograv:master Aug 17, 2023
@abhisrkckl abhisrkckl deleted the profiler-dl-data branch August 18, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants